[PATCH] D154293: [AMDGPU] Replace OperandMatchResultTy with ParseStatus (NFC)

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 1 19:07:19 PDT 2023


barannikov88 created this revision.
Herald added subscribers: foad, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl, arsenm.
Herald added a project: All.
barannikov88 requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

ParseStatus is slightly more convenient to use due to implicit
conversion from bool, which allows to do something like:

  return Error(L, "msg");

when with MatchOperandResultTy it had to be:

  Error(L, "msg");
  return MatchOperand_ParseFail;

It also has more appropriate name since parse* methods are not only for
parsing operands.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D154293

Files:
  llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154293.536563.patch
Type: text/x-patch
Size: 60617 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230702/ab38477b/attachment.bin>


More information about the llvm-commits mailing list