[PATCH] D154291: [RISCV] Replace OperandMatchResultTy with ParseStatus (NFC)
Sergei Barannikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jul 1 16:24:44 PDT 2023
barannikov88 added a comment.
Noticed while refactoring.
================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2456
// Attempt to parse token as a register.
- if (parseRegister(Operands, true) == MatchOperand_Success)
+ if (parseRegister(Operands, true).isSuccess())
return false;
----------------
For now, `parseRegister` can only return Success or NoMatch. If it ever returns Failure, all callsites should be updated.
================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2460
// Attempt to parse token as an immediate
- if (parseImmediate(Operands) == MatchOperand_Success) {
+ if (parseImmediate(Operands).isSuccess()) {
// Parse memory base register if present
----------------
If `parseImmediate` fails, two errors are reported.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154291/new/
https://reviews.llvm.org/D154291
More information about the llvm-commits
mailing list