[PATCH] D154288: [DWARFLinker][NFC] Remove RangesTy &getValidAddressRanges().

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 1 13:12:39 PDT 2023


avl created this revision.
avl added reviewers: JDevlieghere, aprantl, rastogishubham, fdeazeve.
Herald added a subscriber: hiraditya.
Herald added a project: All.
avl requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This patch simplifies line table generation. It removes global
array of all units ranges(RangesTy &getValidAddressRanges()).
The comment says that global array of all units ranges is necessary
to handle corner cases inside line table rows. Removing that
special handling shows that its current usage is handling of
"end of range case" which is already handled correctly
(without special handling). .debug_line tables for clang binary
built with and without this patch are equal.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D154288

Files:
  llvm/include/llvm/DWARFLinker/DWARFLinker.h
  llvm/include/llvm/DWARFLinkerParallel/AddressesMap.h
  llvm/lib/DWARFLinker/DWARFLinker.cpp
  llvm/tools/dsymutil/DwarfLinkerForBinary.h
  llvm/tools/llvm-dwarfutil/DebugInfoLinker.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154288.536551.patch
Type: text/x-patch
Size: 17642 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230701/ac6e9031/attachment.bin>


More information about the llvm-commits mailing list