[PATCH] D154281: [CodeGen] Store SP adjustment in MachineBasicBlock. NFCI.
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jul 1 09:49:28 PDT 2023
foad added inline comments.
================
Comment at: llvm/lib/CodeGen/MIRParser/MIParser.cpp:685
+ unsigned Value = 0;
+ if (getUnsigned(Value) || !isInt<32>(Value))
+ return error("Unknown SP adjustment");
----------------
This won't work for negative values but in practice this value is always >= 0 for ARM (and == 0 for all other in-tree targets). I don't know whether it could ever reasonably be negative on other targets.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154281/new/
https://reviews.llvm.org/D154281
More information about the llvm-commits
mailing list