[PATCH] D144936: [SPARC][IAS] Recognize more SPARCv9 instructions/pseudoinstructions

Koakuma via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 1 08:25:09 PDT 2023


koakuma added inline comments.


================
Comment at: llvm/test/MC/Sparc/sparcv9-atomic-instructions.s:18
 
+        ! CHECK: casl [%i0], %l6, %o2   ! encoding: [0xd5,0xe6,0x11,0x16]
+        casl [%i0], %l6, %o2
----------------
MaskRay wrote:
> The indentation seems unnecessary. It seems that we can unindent all instructions. That's the more common style for instruction encoding in other targets' testing as well.
I can do that with new testfiles, but for old ones I feel like it's better to follow old formattings?
At least I feel like for those files it's better to reformat in a new patch instead of here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144936/new/

https://reviews.llvm.org/D144936



More information about the llvm-commits mailing list