[PATCH] D154280: [LIT] Added an option to llvm-lit to emit the necessary test coverage data, divided per test case
Henrik G Olsson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jul 1 07:00:29 PDT 2023
hnrklssn added a comment.
Please also add a test of lit itself (see `llvm/utils/lit/tests`). I think something using `--emit-coverage` on a test that echoes `$LLVM_PROFILE_FILE` should be enough.
================
Comment at: llvm/utils/lit/lit/TestRunner.py:1124-1125
try:
out, err, exitCode = lit.util.executeCommand(
command,
----------------
This call seems redundant
================
Comment at: llvm/utils/lit/lit/cl_arguments.py:188
+ execution_group.add_argument(
+ "--emit-coverage",
+ dest="emit_coverage",
----------------
Since this option doesn't actually affect whether the tests emit coverage we should probably name it something more descriptive, e.g. `--per-test-coverage` or something to that regard.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154280/new/
https://reviews.llvm.org/D154280
More information about the llvm-commits
mailing list