[PATCH] D154276: [RISCV] Use parseDirective returning ternary status

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2975
   if (parseEOL())
-    return false;
+    return true;
   getTargetStreamer().emitDirectiveVariantCC(
----------------
Is this not a separate change?


================
Comment at: llvm/test/MC/RISCV/invalid-attribute.s:10
 
+.attribute unknown, "unknown"
+# CHECK: [[@LINE-1]]:12: error: attribute name not recognised: unknown
----------------
Test should probably go in separately first to show it's not a behavioural change and just a bug in the conversion(?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154276/new/

https://reviews.llvm.org/D154276