[PATCH] D153829: [AArch64] Move branch relaxation after bbsection assignment

[Daniel Hoekwater via Phabricator via llvm-commits]

dhoekwater marked 2 inline comments as done.
dhoekwater added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetPassConfig.h:444
+  /// function can assume that no pass after it will modify or move any
+  /// instructions. Note that the first pass in this function *can* modify and
+  /// insert instructions as necessary, but no subsequent passes can do so.
----------------
dhoekwater wrote:
> arsenm wrote:
> > I don't understand this, how can such a restriction exist on the use of this?
> It can’t for the same reasons that your other comment addresses, so I’ll have to remove this. I named and documentation this function as I did to convey some of the invariants of the pipeline at the point they’re called, but now I’m confused. Are there _any_ guarantees between `addPreEmitPass` and `addPreEmitPass2` other than Pass 2 happening after pass 1?
Thanks for the feedback; the updated function name and documentation should be more accurate, if a little nondescript.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153829/new/

https://reviews.llvm.org/D153829