[PATCH] D153992: AMDGPU: Remove attempt at simplifying the format string in printf lowering

Fri Jun 30 14:57:06 PDT 2023

rampitec added a comment.

In D153992#4465566 <https://reviews.llvm.org/D153992#4465566>, @arsenm wrote:

> In D153992#4465550 <https://reviews.llvm.org/D153992#4465550>, @rampitec wrote:
>
>> In D153992#4465528 <https://reviews.llvm.org/D153992#4465528>, @arsenm wrote:
>>
>>> Just remove simplifyInstruction because the usage here makes no sense
>>
>> I vaguely remember it was added because we were unable to compile something without it and with -O0. But that was during HSAIL times and likely irrelevant.
>
> I figured it was something like that, but clang -O0 -X -disable-llvm-passes still produces the required direct global reference to printf

>From my recollections we were unable to get to format string. This shall be fine now without.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153992/new/

https://reviews.llvm.org/D153992