[PATCH] D154101: [MC] Add three-state parseDirective as a replacement for ParseDirective

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 30 13:34:19 PDT 2023


dschuff added a comment.

In D154101#4463955 <https://reviews.llvm.org/D154101#4463955>, @barannikov88 wrote:

> It is difficult to write good tests for WebAssembly directives becasue its parseDirective does not track column numbers. It needs larger refactoring, and I don't have time for this. I'll have to leave it to someone else.

Understood, thanks for calling that out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154101/new/

https://reviews.llvm.org/D154101



More information about the llvm-commits mailing list