[PATCH] D154126: [InstCombine] Transform (A > 0) | (A < 0) -> zext (A != 0) fold

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 30 09:56:10 PDT 2023


goldstein.w.n added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/and-or-icmps.ll:2684
+
+}
----------------
Can you split the tests to a seperate patch?

Basically 
Commit 1: Tests
Commit 2: Impl (Update tests so we can see the changes the impl causes)

Then you set the relationship between the patches using the "Edit Related Revisions" Options on Phabricator.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154126/new/

https://reviews.llvm.org/D154126



More information about the llvm-commits mailing list