[PATCH] D152399: [CodeGen] Fine tune MachineFunctionSplitPass (MFS) for FSAFDO.

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish accepted this revision.
snehasish added a comment.
This revision is now accepted and ready to land.

lgtm, thanks for your patience with all the suggestions!



================
Comment at: llvm/lib/CodeGen/MachineFunctionSplitter.cpp:116
+  if (!Count) {
+    // Early return when Count has no value.
     return true;
----------------
Maybe merge this comment with the one above and drop the braces?


================
Comment at: llvm/test/CodeGen/X86/machine-function-splitter.ll:16
 ; MFS-DEFAULTS-NEXT:  callq   baz
+
   br i1 %0, label %2, label %4, !prof !17
----------------
Leftover empty line after moving the code?


================
Comment at: llvm/test/CodeGen/X86/machine-function-splitter.ll:407
+;; HasAccurateProfile is false, foo15 is hot, but no profile data for
+;; blocks, no split should happend.
+; FSAFDO-MFS2-NOT: .section	.text.split.foo15,"ax"
----------------
typo: happen


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152399/new/

https://reviews.llvm.org/D152399