[llvm] a8821c8 - [NVPTX] added a hidden option to control NVPTXLowerUnreachable pass.
Artem Belevich via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 30 08:59:38 PDT 2023
Author: Artem Belevich
Date: 2023-06-30T08:52:23-07:00
New Revision: a8821c8b1ca152827cdab96fe4cb49f3c3c876a1
URL: https://github.com/llvm/llvm-project/commit/a8821c8b1ca152827cdab96fe4cb49f3c3c876a1
DIFF: https://github.com/llvm/llvm-project/commit/a8821c8b1ca152827cdab96fe4cb49f3c3c876a1.diff
LOG: [NVPTX] added a hidden option to control NVPTXLowerUnreachable pass.
We've ran into an issue where the pass breaks a handful of our internal tests
and need a way to temporarily disable the pass while we're investigating.
Differential Revision: https://reviews.llvm.org/D154106
Added:
Modified:
llvm/lib/Target/NVPTX/NVPTXTargetMachine.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Target/NVPTX/NVPTXTargetMachine.cpp b/llvm/lib/Target/NVPTX/NVPTXTargetMachine.cpp
index a530de78f50ae2..1892f951ee835c 100644
--- a/llvm/lib/Target/NVPTX/NVPTXTargetMachine.cpp
+++ b/llvm/lib/Target/NVPTX/NVPTXTargetMachine.cpp
@@ -63,11 +63,18 @@ static cl::opt<bool> UseShortPointersOpt(
"Use 32-bit pointers for accessing const/local/shared address spaces."),
cl::init(false), cl::Hidden);
+// FIXME: intended as a temporary debugging aid. Should be removed before it
+// makes it into the LLVM-17 release.
+static cl::opt<bool>
+ ExitOnUnreachable("nvptx-exit-on-unreachable",
+ cl::desc("Lower 'unreachable' as 'exit' instruction."),
+ cl::init(true), cl::Hidden);
+
namespace llvm {
void initializeGenericToNVVMLegacyPassPass(PassRegistry &);
void initializeNVPTXAllocaHoistingPass(PassRegistry &);
-void initializeNVPTXAssignValidGlobalNamesPass(PassRegistry&);
+void initializeNVPTXAssignValidGlobalNamesPass(PassRegistry &);
void initializeNVPTXAtomicLowerPass(PassRegistry &);
void initializeNVPTXCtorDtorLoweringLegacyPass(PassRegistry &);
void initializeNVPTXLowerAggrCopiesPass(PassRegistry &);
@@ -403,7 +410,8 @@ void NVPTXPassConfig::addIRPasses() {
addPass(createSROAPass());
}
- addPass(createNVPTXLowerUnreachablePass());
+ if (ExitOnUnreachable)
+ addPass(createNVPTXLowerUnreachablePass());
}
bool NVPTXPassConfig::addInstSelector() {
@@ -456,11 +464,10 @@ void NVPTXPassConfig::addOptimizedRegAlloc() {
if (addPass(&MachineSchedulerID))
printAndVerify("After Machine Scheduling");
-
addPass(&StackSlotColoringID);
// FIXME: Needs physical registers
- //addPass(&MachineLICMID);
+ // addPass(&MachineLICMID);
printAndVerify("After StackSlotColoring");
}
More information about the llvm-commits
mailing list