[PATCH] D153696: [LV] Only generate 1st part outside of vector region for VPInstruction.

[Ayal Zaks via Phabricator via llvm-commits]

Ayal added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp:394-400
+  if (isDefinedOutsideVectorRegions()) {
+    generateInstruction(State, 0);
+  } else {
+    for (unsigned Part = 0; Part < State.UF; ++Part)
+      generateInstruction(State, Part);
+  }
 }
----------------
Worth separating the generation of Instruction(s) from setting the State, and be explicit about both, as in the above?

Can check hasResult() instead of num users to ensure that the generated instruction produces a value, or have generateInstruction() return null if the Instruction(s) it produces do not supply a result that can be used, as in stores and branches.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153696/new/

https://reviews.llvm.org/D153696