[PATCH] D154119: Fix: Distinguish CFI Metadata Checks in MergeFunctions Pass

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/FunctionComparator.cpp:632
+      }
+    }
+
----------------
oskarwirga wrote:
> nikic wrote:
> > This doesn't looks like a problem specific to the type.test intrinsic. Other calls may have metadata operands as well.
> Should I remove the intrinsic check and instead loop through the arg operands to check that they are the same? 
The caller cmpBasicBlocks() already does a loop over the operands and compares them via cmpValues(). So that's probably the place where MetadataAsValue needs to be handled.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154119/new/

https://reviews.llvm.org/D154119