[PATCH] D154205: [MachineLICM] Handle subloops

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

It has always been a bit strange that this only tries to sink out of outermost loops. This looks like it will try the largest loop first, which sound like it makes sense.

Are there other tests that need to be updated?



================
Comment at: llvm/test/CodeGen/AArch64/machine-licm-sub-loop.ll:5
 ; Function Attrs: nofree norecurse nosync nounwind memory(argmem: readwrite) uwtable
 define dso_local void @foo(i32 noundef %limit, ptr nocapture noundef %out, ptr nocapture noundef readonly %y) local_unnamed_addr #0 {
 ; CHECK-LABEL: foo:
----------------
I tend to remove the `Function Attrs` along with `dso_local` and the `local_unnamed_addr #0`


================
Comment at: llvm/test/CodeGen/AArch64/machine-licm-sub-loop.ll:168-169
 
 !llvm.module.flags = !{!0, !1, !2, !3, !4}
 !llvm.ident = !{!5}
 
----------------
I don't believe these are used for anything.


================
Comment at: llvm/test/CodeGen/AArch64/machine-licm-sub-loop.ll:171
 
 !0 = !{i32 1, !"wchar_size", i32 4}
 !1 = !{i32 8, !"PIC Level", i32 2}
----------------
And can you remove as much of this as you can.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154205/new/

https://reviews.llvm.org/D154205