[PATCH] D153436: [CSKY] Optimize IR pattern icmp-select with INCT32/INCF32

[Zixuan Wu via Phabricator via llvm-commits]

zixuan-wu added a comment.

In D153436#4463080 <https://reviews.llvm.org/D153436#4463080>, @benshi001 wrote:

> In D153436#4462890 <https://reviews.llvm.org/D153436#4462890>, @benshi001 wrote:
>
>> In D153436#4462763 <https://reviews.llvm.org/D153436#4462763>, @zixuan-wu wrote:
>>
>>> No more further comments. I just go through inct-incf.ll without too much detail. I hope all added Pats are all covered in inct-incf.ll
>>
>> Sure. I will have a double check about your concern.
>
> I have checked and I think each newly added `Pat` is covered.
>
>   (select (var0 == var1))
>   (select (var0 != var1))
>   (select (unsigned var0 >= var1))
>   (select (signed var0 >= var1))
>   (select (unsigned var0 > var1))
>   (select (signed var0 > var1))
>   (select (unsigned var0 < var1))
>   (select (signed var0 < var1))
>   (select (unsigned var0 <= var1))
>   (select (signed var0 <= var1))
>   (select (var == immediate))
>   (select (var != immediate))
>   (select (unsigned var >= immediate))
>   (select (signed var >= immediate))
>   (select (unsigned var > immediate))
>   (select (signed var > immediate))
>   (select (unsigned var < immediate))
>   (select (signed var < immediate))
>   (select (unsigned var <= immediate))
>   (select (signed var <= immediate))
>   (select (non comparison bool condition)) // a function call return bool

LGTM


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153436/new/

https://reviews.llvm.org/D153436