[PATCH] D154187: [InstCombine] Add test cases from PR63321. NFC.

Yingwei Zheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 30 00:59:40 PDT 2023


dtcxzyw added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/binop-cast.ll:303
+
+; Negative test of and_add_bool_to_select
+define i32 @and_add_bool_no_fold(i32 %y) {
----------------
I am not sure that it should not be folded into select.

D153148 folds it into select and seems to generate better instruction seq.

x86-64: https://godbolt.org/z/jv9v9xTMT
riscv64: https://godbolt.org/z/zTbbnn9x4
arm: https://godbolt.org/z/eK6xWKnrb



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154187/new/

https://reviews.llvm.org/D154187



More information about the llvm-commits mailing list