[PATCH] D153434: [CSKY][NFC][test] Add tests of IR pattern icmp-select

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 30 00:12:36 PDT 2023


benshi001 added inline comments.


================
Comment at: llvm/test/CodeGen/CSKY/dect-decf.ll:365
+
+define i32 @select_by_call_f(i32 %t0, i32 %t1, i32 %t2) {
+; CHECK-LABEL: select_by_call_f:
----------------
zixuan-wu wrote:
> Any need to construct such pattern with call? Although, no harm of more test.
This call test is for the Pat

```
def : Pat<(select CARRY:$ca, (add GPR:$rx, uimm5:$imm), GPR:$false),
          (INCT32 CARRY:$ca, GPR:$false, GPR:$rx, uimm5:$imm)>;
def : Pat<(select CARRY:$ca, GPR:$true, (add GPR:$rx, uimm5:$imm)),
          (INCF32 CARRY:$ca, GPR:$true, GPR:$rx, uimm5:$imm)>;
```

in https://reviews.llvm.org/D153436, you can see the improvement in this call test at there.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153434/new/

https://reviews.llvm.org/D153434



More information about the llvm-commits mailing list