[PATCH] D153934: [SelectionDAG][TargetLowering]Add support for nuw/nsw on KnownBits::shl

[Liao Chunyu via Phabricator via llvm-commits]

liaolucy added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/rv64i-demanded-bits.ll:197
+
+define i32 @test_shl_nuw__nsw_is_safe(i32 %x) {
+; CHECK-LABEL: test_shl_nuw__nsw_is_safe:
----------------
RKSimon wrote:
> please can you precommit this test with current trunk codegen and then rebase this patch to show the diff
Thanks for the review. In fact, I found not only good testcase, but also bad ones.
Regarding the bad testcase, no solution has been found for the time being. 
I'll come back to this patch later when I find a solution. Thanks again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153934/new/

https://reviews.llvm.org/D153934