[PATCH] D150464: [FuncSpec] Improve the accuracy of the cost model.

Thu Jun 29 15:14:52 PDT 2023

thevinster added a comment.

In D150464#4444716 <https://reviews.llvm.org/D150464#4444716>, @thevinster wrote:

> @labrinea This change hits a crash when trying to build lld with thinLTO (i.e. stage2 lld) and with assertions enabled. I verified that the revision before this change works. I get the following assertion failure
>
>   opt: <workspace>/llvm-project/llvm/include/llvm/Support/Casting.h:578: decltype(auto) llvm::cast(From *) [To = llvm::ConstantInt, From = llvm::Constant]: Assertion `isa<To>(Val) && "cast<Ty>() argument of incompatible type!"' failed.
>
> I reduced the issue and this can be reproed by building opt on this revision and then running
>
>   $ opt reduced.ll -o /dev/null -O3
>
> where reduced.ll is https://reviews.llvm.org/P8311
>
> Could you please take a look and advise the path forward?
>
> cc: @smeenai

I put up D154159 <https://reviews.llvm.org/D154159> that should address the crashing issue.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150464/new/

https://reviews.llvm.org/D150464