[PATCH] D154087: Upstream Cygwin Clang patches

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 29 15:01:59 PDT 2023


MaskRay added a comment.

As Eli said, we need some tests. Also see https://maskray.me/blog/2021-08-08-toolchain-testing#i-dont-know-whether-a-test-is-needed
For other contributors who may improve or refactor the code, without the code they can't know whether their changes will break your functionality.

"I don't know where to add a test" may be relevant. If you don't know where to add a test, comment out some code and run `ninja check-llvm check-clang` to identify test locations.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154087/new/

https://reviews.llvm.org/D154087



More information about the llvm-commits mailing list