[PATCH] D154019: [IR] Ignore globals with the `llvm.` prefix when calculating module hash

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 29 13:58:31 PDT 2023


aeubanks added inline comments.


================
Comment at: llvm/unittests/IR/PassManagerTest.cpp:1090
+
+TEST_F(PassManagerTest, ModulePassNoAnalysisInvalidation) {
+  LLVMContext Context;
----------------
I've been meaning to write some unittests that specifically just check (in)equality of `llvm::StructuralHash` of two modules so we can avoid doing that. Going through a pass manager shouldn't be necessary. I can do that, or if you have time you can start that :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154019/new/

https://reviews.llvm.org/D154019



More information about the llvm-commits mailing list