[PATCH] D154125: MachineFunction: -fsanitize={function, kcfi}: ensure 4-byte alignment
Sami Tolvanen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 29 13:32:25 PDT 2023
samitolvanen accepted this revision.
samitolvanen added a comment.
This revision is now accepted and ready to land.
Thanks for fixing this! This approach looks good to me.
================
Comment at: llvm/test/CodeGen/RISCV/kcfi-patchable-function-prefix.ll:6-7
+;; instrumented function is indirectly called.
; NOC: .p2align 2
-; C: .p2align 1
+; C: .p2align 2
; CHECK-NOT: nop
----------------
Nit: These checks are the same now, so we can replace both lines with one `CHECK:` line. Also the other instance below.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154125/new/
https://reviews.llvm.org/D154125
More information about the llvm-commits
mailing list