[PATCH] D154135: AMDGPU: Implement GlobalIsel for llvm.get.fpenv

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/Support/TargetOpcodes.def:625
 
+/// Get Floating point environmet
+HANDLE_TARGET_OPCODE(G_GET_FPENV)
----------------
Typo environmet


================
Comment at: llvm/include/llvm/Target/GenericOpcodes.td:992
 
+// This returns Floating point environmet value.
+def G_GET_FPENV : GenericInstruction {
----------------
Typo environmet


================
Comment at: llvm/test/CodeGen/AMDGPU/llvm.get.fpenv.ll:8
+; RUN: llc -march=amdgcn -global-isel -mcpu=gfx1100 -amdgpu-enable-delay-alu=0 < %s | FileCheck -check-prefixes=GCN,GFX1011,GFX11 %s
+; RUN: llc -march=amdgcn -mcpu=tahiti < %s | FileCheck -check-prefixes=GCN,GFX678,GFX6 %s
+; RUN: llc -march=amdgcn -mcpu=hawaii < %s | FileCheck -check-prefixes=GCN,GFX678,GFX7 %s
----------------
I assume something weird happened in the diff, but the test should just add run lines to the existing test. the dag tests should also use an explicit -global-isel=0


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154135/new/

https://reviews.llvm.org/D154135