[PATCH] D153101: [SPIR-V] Simplify regclasses hierarchy and cleanup regbanks

[Ilia Diachkov via Phabricator via llvm-commits]

iliya-diyachkov added a comment.

In general it looks fine. We also need to check testing results.



================
Comment at: llvm/lib/Target/SPIRV/SPIRVInstrInfo.td:99
                   "$res = OpExtInstImport $extInstsName">;
-def OpExtInst: Op<12, (outs ID:$res), (ins TYPE:$ty, ID:$set, Extension:$inst, variable_ops),
+def OpExtInst: Op<12, (outs ID:$res), (ins TYPE:$ty, i32imm:$set, Extension:$inst, variable_ops),
                   "$res = OpExtInst $ty $set $inst">;
----------------
Should `$set` be `i32imm`, not `ID`? `OpExtInstImport`'s result is still `ID`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153101/new/

https://reviews.llvm.org/D153101