[PATCH] D153534: [lit] Remove dead code not referenced, documented or tested anywhere

Louis Dionne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 29 12:00:42 PDT 2023


ldionne added a comment.

In D153534#4461054 <https://reviews.llvm.org/D153534#4461054>, @yln wrote:

> Do we need to worry about out-of-tree users?

We might, but do we have a way to know about those? At the very least this isn't tested and there's a bunch of `TODO`s in it, so it seems like it's not something we're super proud of.

Personally, I would remove it and then ask for forgiveness if we break some people (and then I'd probably suggest that these folks should maintain their own copy of this class instead of Lit providing it, unless there's many users that are broken).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153534/new/

https://reviews.llvm.org/D153534



More information about the llvm-commits mailing list