[PATCH] D154101: [MC] Add three-state parseDirective as a replacement for ParseDirective

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 29 11:36:59 PDT 2023


MaskRay added a comment.

Minor suggestion to the summary: I think you can say that `AsmParser::parseStatement` has the fragile heuristic in the first paragraph, so that curious readers can find this important location immediately.
Otherwise due to changes to a lot of lib/Target code, they may not notice this quickly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154101/new/

https://reviews.llvm.org/D154101



More information about the llvm-commits mailing list