[PATCH] D154027: [CSSPGO] Enable stale profile matching by default for CSSPGO
Lei Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 29 11:19:23 PDT 2023
This revision was automatically updated to reflect the committed changes.
Closed by commit rG444d2e1a5405: [CSSPGO] Enable stale profile matching by default for CSSPGO (authored by wlei).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154027/new/
https://reviews.llvm.org/D154027
Files:
llvm/lib/Transforms/IPO/SampleProfile.cpp
Index: llvm/lib/Transforms/IPO/SampleProfile.cpp
===================================================================
--- llvm/lib/Transforms/IPO/SampleProfile.cpp
+++ llvm/lib/Transforms/IPO/SampleProfile.cpp
@@ -2048,6 +2048,16 @@
UsePreInlinerDecision = true;
}
+ // Enable stale profile matching by default for probe-based profile.
+ // Currently the matching relies on if the checksum mismatch is detected,
+ // which is currently only available for pseudo-probe mode. Removing the
+ // checksum check could cause regressions for some cases, so further tuning
+ // might be needed if we want to enable it for all cases.
+ if (Reader->profileIsProbeBased() &&
+ !SalvageStaleProfile.getNumOccurrences()) {
+ SalvageStaleProfile = true;
+ }
+
if (!Reader->profileIsCS()) {
// Non-CS profile should be fine without a function size budget for the
// inliner since the contexts in the profile are either all from inlining
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154027.535929.patch
Type: text/x-patch
Size: 989 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230629/a46b2752/attachment.bin>
More information about the llvm-commits
mailing list