[PATCH] D154124: [WebAssembly] Fix incorrect assertion in SIMD reduction codegen

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 29 11:09:06 PDT 2023


tlively created this revision.
tlively added reviewers: aheejin, dschuff.
Herald added subscribers: pmatos, asb, wingo, sunfish, hiraditya, jgravelle-google, sbc100.
Herald added a project: All.
tlively requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The codegen routine introduced in 18077e9fd688 <https://reviews.llvm.org/rG18077e9fd688443ca111111541e7e3a71236efd5> did not account for vectors with
more than 16 lanes. Remove the incorrect assertion and bail out of the
optimization when encountering this case. Add test cases that previously
triggered the assertion. Unfortunately, these test cases now have terrible
codegen, but that is at least better than crashing.

Fixes #63500.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D154124

Files:
  llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
  llvm/test/CodeGen/WebAssembly/simd-vecreduce-bool.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154124.535916.patch
Type: text/x-patch
Size: 39671 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230629/dd44032d/attachment.bin>


More information about the llvm-commits mailing list