[PATCH] D149742: [SLP]Improve isGatherShuffledEntry by trying per-register shuffle.

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added a comment.

In D149742#4401811 <https://reviews.llvm.org/D149742#4401811>, @vdmitrie wrote:

> F27851102: test.ll <https://reviews.llvm.org/F27851102>
>
> command to reproduce: opt -passes=slp-vectorizer -mtriple=x86_64 -mcpu=core-avx2 -S test.ll

HMM, llvm-mca shows that the code after patch is better than the code before (with the patch the throughput is 4.0, without - 5.0)

> BTW. which gcc version you use to build? I've experienced problem building with both 7.5.0 and 8.5.0 (I did not try any later versions) while there were no issues w/o patch.
> Here is fail log:
> <dir>/llvm-project/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:3573:24: error: declaration of llvm::TargetTransformInfo* llvm::slpvectorizer::BoUpSLP::TTI [-fpermissive]
>
>   TargetTransformInfo *TTI;
>                        ^~~
>
> In file included from <dir>/llvm-project/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:47:0:
> <dir>/llvm-project/llvm/include/llvm/Analysis/TargetTransformInfo.h:205:29: error: changes meaning of TTI from typedef class llvm::TargetTransformInfo llvm::TTI [-fpermissive]
>  typedef TargetTransformInfo TTI;
>
>   ^~~

It is most probably because of the using TTI:: in the function declaration, will fix this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149742/new/

https://reviews.llvm.org/D149742