[PATCH] D89049: [AIX][XCOFF] print out the traceback info

[Digger Lin via Phabricator via llvm-commits]

DiggerLin marked 4 inline comments as done.
DiggerLin added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/disassemble-traceback-table.test:55
+
+# CHECK:00000000 (idx: 0) .AddNum[PR]:
+# CHECK-NEXT:       0: 94 21 ff c0  	stwu 1, -64(1)
----------------
MaskRay wrote:
> 
the original output as 


```
00000000 (idx: 0) .AddNum[PR]:
       0: 94 21 ff c0   stwu 1, -64(1)
       4: 00 00 00 00   # Traceback table start


00000024 (idx: 2) .foo[PR]:
      24: 93 e1 ff fc   stw 31, -4(1)
      28: 00 00 00 00   # Traceback table start
      2c: 00            # Version = 0
```


00000000 (idx: 0) .AddNum[PR]: 
00000024 (idx: 2) .foo[PR]:

are label, there start from column zero.

and the test case use  --strict-whitespace 
so I have to keep as 
   CHECK:00000000 (idx: 0) .AddNum[PR]:


================
Comment at: llvm/tools/llvm-objdump/ObjdumpOpts.td:66
 
 def symbol_description : Flag<["--"], "symbol-description">,
   HelpText<"Add symbol description for disassembly. This "
----------------
jhenderson wrote:
> MaskRay wrote:
> > I think it's time to use `Group<grp_xcoff>;`, then you can omit `This option is for XCOFF files only` since the options will be listed with a `--help` section named XCOFF. See `grp_mach_o` for an example.
> Makes sense to me (probably it should be a subsequent patch though).
thanks. I will do it  in subsequent patch for this comment. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89049/new/

https://reviews.llvm.org/D89049