[PATCH] D153097: [RISCV] Make linker-relaxable instructions terminate MCDataFragment

[Alex Bradbury via Phabricator via llvm-commits]

asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.

I've stepped through the patch description and the code - both of which make sense to me. I'm not familiar enough with the code to be certain there's not an alternative way of achieving the same thing that would be better....but then I'd normally looking to @maskray for such suggestions :) LGTM, just left a minor query regarding tweaking a doc comment.



================
Comment at: llvm/include/llvm/MC/MCAsmBackend.h:54
 
+  /// Fixup kind for RISC-V linker relaxation.
+  const unsigned RelaxFixupKind;
----------------
I assume the point of labelling this as RISC-V thing is to note that it hasn't been put to use across multiple targets. So perhaps "Fixup kind used for linker relaxation. Currently only used by RISC-V" might be a better description? (i.e. in theory general code, but hasn't been used in practice outside of one target).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153097/new/

https://reviews.llvm.org/D153097