[PATCH] D152706: [AMDGPU] Use SSAUpdater in PromoteAlloca

[Pierre van Houtryve via Phabricator via llvm-commits]

Pierre-vh added a comment.

In D152706#4459459 <https://reviews.llvm.org/D152706#4459459>, @arsenm wrote:

> In D152706#4458582 <https://reviews.llvm.org/D152706#4458582>, @Pierre-vh wrote:
>
>> It leads to less folding than I'd like, but it's a lot more correct.
>
> Do you have an example of this?

Look in `promote-alloca-loadstores.ll`, the first testcase, one of the insertelement is useless (gets overwritten right away)
It's very minor things so I don't think it's a big issue


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152706/new/

https://reviews.llvm.org/D152706