[PATCH] D153421: [mlir][Linalg] Implement the tiling interface for softmax

[Jacques Pienaar via Phabricator via llvm-commits]

jpienaar added inline comments.


================
Comment at: mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:53
+                         int64_t dim) {
+  ShapedType type = v.getType().cast<ShapedType>();
+  if (!type.isDynamicDim(dim)) {
----------------
This is the deprecated form https://mlir.llvm.org/deprecation/


================
Comment at: mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:2239
+  Operation *tiledOp =
+      mlir::clone(builder, getOperation(), resultTypes, tiledOperands);
+
----------------
s/mlir:://


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153421/new/

https://reviews.llvm.org/D153421