[PATCH] D153422: [mlir][Linalg] Add a softmax op

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet marked 7 inline comments as done.
qcolombet added inline comments.


================
Comment at: mlir/include/mlir/Dialect/Linalg/IR/LinalgOps.td:125
+  let extraClassDeclaration = [{
+    Value input() {
+      return getInput();
----------------
chelini wrote:
> Any specific reason for having this wrapper?  Can we use the method generated by tablegen directly `getInput`? Same for `getOutput`.
Ah thanks, forgot to clean that out.
It made the porting from IREE easier.


================
Comment at: mlir/include/mlir/Dialect/Linalg/IR/LinalgOps.td:144
+    // Method to implement for specifying output range for
+    // DestinationStyleOpInterface
+    std::pair<int64_t, int64_t> getDpsInitsPositionRange() {
----------------
chelini wrote:
> I cannot fully understand the sentence, maybe something like: `Implement functions necessary for DestinationStyleOpInterface.`
Good catch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153422/new/

https://reviews.llvm.org/D153422