[PATCH] D153326: [CSKY] Optimize subtraction with SUBI32/SUBI16

Zixuan Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 29 02:25:02 PDT 2023


zixuan-wu added inline comments.


================
Comment at: llvm/lib/Target/CSKY/CSKYInstrInfo.td:105
 
+def oimm_neg_XFORM : SDNodeXForm<imm, [{
+  return CurDAG->getTargetConstant(-N->getSExtValue(), SDLoc(N), MVT::i32);
----------------
I think there is no oimm specific meaning, just use imm_neg or neg_imm would be fine.


================
Comment at: llvm/test/CodeGen/CSKY/base-i.ll:43
 
+define i32 @addRI_256(i32 %x) {
+; CHECK-LABEL: addRI_256:
----------------
Is this case related to this patch change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153326/new/

https://reviews.llvm.org/D153326



More information about the llvm-commits mailing list