[PATCH] D109821: [ScalarEvolution] Infer loop max trip count from array accesses

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 29 00:47:45 PDT 2023


xbolva00 added a subscriber: aeubanks.
xbolva00 added a comment.

In D109821#4313669 <https://reviews.llvm.org/D109821#4313669>, @xbolva00 wrote:

> In D109821#3095496 <https://reviews.llvm.org/D109821#3095496>, @Peakulorain wrote:
>
>> The remaining bugs have been clearly described in the code comments, and I will fix them in the next step. This API is disabled by default now.
>
> Did you fix them?

As lot of time passed and it seems like no progress on bugs was made. I think you should revert this patch. I think it is a bad practise to commit known buggy features, even if disabled by default.

@nikic @aeubanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109821/new/

https://reviews.llvm.org/D109821



More information about the llvm-commits mailing list