[PATCH] D154010: [InstCombine] Canonicalize `getelementptr` patterns to `@llvm.ptrmask`

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

Can you please add proofs for cases 2 and 3?

This generally looks find to me, but I think we need slightly better ptrmask support before we land this. My minimum expectation would be ability to fold away ptrmask on already aligned pointers.



================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:2249
+                                    {Ptr, Mask});
+      // (getelementptr i8, Ptr (sub 0, (and (ptrtoint Ptr), CMask)))
+      //      -> llvm.ptrmask(Ptr, ~CMask)
----------------
Missing `,` after Ptr.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154010/new/

https://reviews.llvm.org/D154010