[PATCH] D150525: [libc++][memory] P1132R8: out_ptr - a scalable output pointer abstraction

[Hristo Hristov via Phabricator via llvm-commits]

H-G-Hristov marked an inline comment as done.
H-G-Hristov added inline comments.


================
Comment at: libcxx/include/__iterator/cpp17_iterator_concepts.h:77
+    __cpp17_equality_comparable<_Ptr> && __cpp17_default_constructible<_Ptr> && __cpp17_copy_constructible<_Ptr> &&
+    __cpp17_move_assignable<_Ptr> && __cpp17_swappable<_Ptr> && requires(std::nullptr_t __np) {
+      requires requires(_Ptr __u) {
----------------
This concept and the other above should probably be moved to another location?


================
Comment at: libcxx/include/__memory/allocator_traits.h:38
     template <class _Tp, class = void> struct NAME : false_type { };    \
     template <class _Tp>               struct NAME<_Tp, __void_t<typename _Tp:: PROPERTY > > : true_type { }
 
----------------
Should this be renamed and moved to a more central location so it can be reused?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150525/new/

https://reviews.llvm.org/D150525