[PATCH] D153927: Resubmit: [Analysis] Refactor MBB hotness/coldness into templated PSI functions

Wed Jun 28 22:13:35 PDT 2023

shenhan added a comment.

In D153927#4458106 <https://reviews.llvm.org/D153927#4458106>, @MaskRay wrote:

> Thanks. This change should support Bazel builds.
>
>> The origin CL D152758 <https://reviews.llvm.org/D152758> caused gcc-12 build failures, which is caused by a gcc bug, and won't be fixed in version 12.
>
> "CL" means https://opensource.google/documentation/reference/glossary#changelist , but our term is Differential, or just "patch" :)

Done.

> In fact, I'd suggest that you remove
>
>> Below is origin CL description.
>>
>> [NFC] Refactor MBB hotness/coldness into templated PSI functions.
>
> Just start with the original description. You can add information in last paragraph about what's changed from the reverted (two?) commits.

Done

>> In D152399 <https://reviews.llvm.org/D152399>, we calculate BPI->BFI in MachineFunctionSplit pass just to use PSI->isFunctionHotInCallGraph, which is expensive. Instead, we can implement this directly with MBFI.
>
> Since this patch will land before D152399 <https://reviews.llvm.org/D152399> , describing the situation with D152399 <https://reviews.llvm.org/D152399> as the subject may be confusing. I suggest that you describe the current code structure, pretending that D152399 <https://reviews.llvm.org/D152399> does not exist.
> Then, if you think appropriate, describe that this refactoring will make D152399 <https://reviews.llvm.org/D152399> more focused.

Revised the description.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153927/new/

https://reviews.llvm.org/D153927