[PATCH] D154027: [CSSPGO] Enable stale profile matching by default for CSSPGO

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 17:50:21 PDT 2023


wenlei added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:2053
+    if (Reader->profileIsProbeBased()) {
+      if (!SalvageStaleProfile.getNumOccurrences())
+        SalvageStaleProfile = true;
----------------
nit: combine the two ifs. 

also add a comment why pseudo probe is needed. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154027/new/

https://reviews.llvm.org/D154027



More information about the llvm-commits mailing list