[PATCH] D154020: [BOLT] Introduce Rewriter interface

Amir Ayupov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 17:38:10 PDT 2023


Amir accepted this revision.
Amir added a comment.
This revision is now accepted and ready to land.

Looks good and nicely factored.



================
Comment at: bolt/include/bolt/Rewrite/RewriteManager.h:48
+
+  /// Use this static method to access global RewriteManager instance.
+  static RewriteManager *getManager();
----------------
Why a global instance and not a RewriteInstance member variable?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154020/new/

https://reviews.llvm.org/D154020



More information about the llvm-commits mailing list