[PATCH] D152120: [M68k][MC] Add support for 32 bit register-register multiply/divide

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu accepted this revision.
myhsu added a comment.
This revision is now accepted and ready to land.

LGTM with minor comments. Thanks!
Also, since now there are several LLVM patches under your belt, you might want to obtain a commit access <https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access>. Let me know if you need any help on that!



================
Comment at: llvm/lib/Target/M68k/M68kInstrArithmetic.td:637
 
+def "SDIVd32d32" : MxDiMuOp_DD_Long<"divs.l", 0x131, /*SIGNED*/true>;
+def "UDIVd32d32" : MxDiMuOp_DD_Long<"divu.l", 0x131, /*SIGNED*/false>;
----------------
nit: the double quotes are not necessary. Ditto for other occurrences in this patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152120/new/

https://reviews.llvm.org/D152120