[PATCH] D89049: [AIX][XCOFF] print out the traceback info

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.

I only spot checked this and this looks good.



================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/disassemble-traceback-table.test:55
+
+# CHECK:00000000 (idx: 0) .AddNum[PR]:
+# CHECK-NEXT:       0: 94 21 ff c0  	stwu 1, -64(1)
----------------



================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/disassemble-traceback-table.test:78
+
+# CHECK:00000024 (idx: 2) .foo[PR]:
+# CHECK-NEXT:      24: 93 e1 ff fc  	stw 31, -4(1)
----------------
ditto. align


================
Comment at: llvm/tools/llvm-objdump/ObjdumpOpts.td:66
 
 def symbol_description : Flag<["--"], "symbol-description">,
   HelpText<"Add symbol description for disassembly. This "
----------------
I think it's time to use `Group<grp_xcoff>;`, then you can omit `This option is for XCOFF files only` since the options will be listed with a `--help` section named XCOFF. See `grp_mach_o` for an example.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89049/new/

https://reviews.llvm.org/D89049