[PATCH] D153499: [RISCV] Add support for custom CSRs for Sifive S76.

[garvit gupta via Phabricator via llvm-commits]

garvitgupta08 marked 2 inline comments as done.
garvitgupta08 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVSystemOperands.td:23
+  // AltName to be used by Vendors for Custom Vendor Extension.
+  string AltName = "";
   // A maximum of one deprecated name is supported right now.  Unlike the
----------------
craig.topper wrote:
> Do we only allow one vendor to implement an alternate name?
Currently yes. 


================
Comment at: llvm/lib/Target/RISCV/RISCVSystemOperands.td:43
 
 def SysRegsList : GenericTable {
   let FilterClass = "SysReg";
----------------
craig.topper wrote:
> I wonder if maybe we should have a separate table for alternate registers?
Can you elaborate on this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153499/new/

https://reviews.llvm.org/D153499