[PATCH] D146776: Reland [llvm] Preliminary fat-lto-objects support

[Paul Kirth via Phabricator via llvm-commits]

paulkirth marked an inline comment as done.
paulkirth added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/EmbedBitcodePass.cpp:51
+
+  return PreservedAnalyses::all();
+}
----------------
aeubanks wrote:
> paulkirth wrote:
> > Is there another option we can use here. `none` seems like overkill. Since this is basically the first thing to run on the module, I'm not sure if there is much point in trying to do anything smarter, but it certainly doesn't feel right.
> perhaps something like https://reviews.llvm.org/D153855?
That seems like it will work. Thanks for the suggestion. We can go back to `none` if we're unhappy about amending the structural hash.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146776/new/

https://reviews.llvm.org/D146776