[PATCH] D150133: [RISCV] Support constant immediate for la pseudo instruction

Wed Jun 28 13:22:13 PDT 2023

garvitgupta08 added a comment.

In D150133#4451187 <https://reviews.llvm.org/D150133#4451187>, @craig.topper wrote:

> In D150133#4451173 <https://reviews.llvm.org/D150133#4451173>, @garvitgupta08 wrote:
>
>> In D150133#4449904 <https://reviews.llvm.org/D150133#4449904>, @craig.topper wrote:
>>
>>> Are we going to fix the same compatibility issue with "lla" and "lga"?
>>
>> I do not plan to work on it at the moment.
>
> Would supporting that justify the approach using bare_symbol_or_constant?

I have added support for lla as well. I believe that having a separate definition for immediate operand is much clean and readable than modifying the existing implementation (as shown in the diff above).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150133/new/

https://reviews.llvm.org/D150133