[PATCH] D153966: [SimplifyCFG] Allow dropping block that only contains ephemeral values

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 13:14:55 PDT 2023


nikic added a comment.

In D153966#4457087 <https://reviews.llvm.org/D153966#4457087>, @aeubanks wrote:

> any thoughts on https://discourse.llvm.org/t/llvm-assume-blocks-optimization/71609/19 and doing this in AssumeSimplifyPass instead of in SimplifyCFG?

I think these approaches are largely orthogonal: One is about dropping assumes to enable a specific transform, the other is about dropping assumes that are "unprofitable" according to some heuristic. These are likely to have some overlap, but unless you want to tailor the profitability heuristic exactly to the legality conditions of specific transforms, you can't subsume the former with the latter.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153966/new/

https://reviews.llvm.org/D153966



More information about the llvm-commits mailing list