[PATCH] D153992: AMDGPU: Avoid computing dominator tree for printf lowering

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPrintfRuntimeBinding.cpp:505
+  auto GetDT = [&FAM](Function &F) -> DominatorTree * {
+    return FAM.getCachedResult<DominatorTreeAnalysis>(F);
   };
----------------
arsenm wrote:
> nikic wrote:
> > Cached analyses on the NewPM should only be used for analyses preservation. You should either require DT here or not use it at all.
> I don't see anything about this in the comments on getCachedResult
Is this not identical to how getBestSimplifyQuery uses this?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153992/new/

https://reviews.llvm.org/D153992